Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-1.23] Backport bugfixes and enhancements from master #5594

Merged
merged 2 commits into from May 21, 2022

Conversation

brandond
Copy link
Contributor

@brandond brandond commented May 20, 2022

Proposed Changes

Backport bugfixes and enhancements from master to release-1.23

Types of Changes

backports

Verification

See linked issues

Linked Issues

User-Facing Change

Objects will be removed from Kubernetes when they are removed from manifest files.

Further Comments

thedadams and others added 2 commits May 20, 2022 14:32
* Remove objects when removed from manifests

If a user puts a file in /var/lib/rancher/k3s/server/manifests/ then the
objects contained therein are deployed to the cluster. If the objects
are removed from that file, they are not removed from the cluster.

This change tracks the GVKs in the files and will remove objects when
there are removed from the cluster.

Signed-off-by: Donnie Adams <donnie.adams@suse.com>
(cherry picked from commit c38a8c3)
Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
(cherry picked from commit 1ef3472)
@brandond brandond requested a review from a team as a code owner May 20, 2022 21:37
@codecov-commenter
Copy link

codecov-commenter commented May 20, 2022

Codecov Report

❗ No coverage uploaded for pull request base (release-1.23@e6385b2). Click here to learn what that means.
The diff coverage is n/a.

@@              Coverage Diff               @@
##             release-1.23   #5594   +/-   ##
==============================================
  Coverage                ?   9.86%           
==============================================
  Files                   ?     136           
  Lines                   ?    9821           
  Branches                ?       0           
==============================================
  Hits                    ?     969           
  Misses                  ?    8658           
  Partials                ?     194           
Flag Coverage Δ
unittests 9.86% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e6385b2...f1cc71f. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants