Delay service readiness until after startuphooks have finished #5649
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandond
reviewed
Jun 6, 2022
…systemd Signed-off-by: Derek Nola <derek.nola@suse.com>
Signed-off-by: Derek Nola <derek.nola@suse.com>
Signed-off-by: Derek Nola <derek.nola@suse.com>
Signed-off-by: Derek Nola <derek.nola@suse.com>
dereknola
force-pushed
the
startuphooks_wait
branch
from
cd36819
to
b059965
Compare
Signed-off-by: Derek Nola <derek.nola@suse.com>
brandond
requested changes
Jun 13, 2022
|
I've already done this. I have a RKE2 PR waiting in the wings for this PR to merge. |
Signed-off-by: Derek Nola <derek.nola@suse.com>
Signed-off-by: Derek Nola <derek.nola@suse.com>
brandond
requested changes
Jun 14, 2022
Signed-off-by: Derek Nola <derek.nola@suse.com>
brandond
approved these changes
Jun 14, 2022
briandowns
approved these changes
Jun 15, 2022
dereknola
added a commit
to dereknola/k3s
that referenced
this pull request
Jun 15, 2022
…o#5649) * Move startup hooks wg into a runtime pointer, check before notifying systemd * Switch default systemd notification to server * Add 1 sec delay to allow etcd to write to disk Signed-off-by: Derek Nola <derek.nola@suse.com>
dereknola
added a commit
to dereknola/k3s
that referenced
this pull request
Jun 15, 2022
…o#5649) * Move startup hooks wg into a runtime pointer, check before notifying systemd * Switch default systemd notification to server * Add 1 sec delay to allow etcd to write to disk Signed-off-by: Derek Nola <derek.nola@suse.com>
dereknola
added a commit
to dereknola/k3s
that referenced
this pull request
Jun 15, 2022
…o#5649) * Move startup hooks wg into a runtime pointer, check before notifying systemd * Switch default systemd notification to server * Add 1 sec delay to allow etcd to write to disk Signed-off-by: Derek Nola <derek.nola@suse.com>
This was referenced Jun 15, 2022
dereknola
added a commit
that referenced
this pull request
Jun 15, 2022
#5723) * Move startup hooks wg into a runtime pointer, check before notifying systemd * Switch default systemd notification to server * Add 1 sec delay to allow etcd to write to disk Signed-off-by: Derek Nola <derek.nola@suse.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
This PR introduces 3 changes
This has the net result of delaying the return of calls to
systemctl restart k3suntil after the startup hooks have finished and k3s is in a more "ready" state.Types of Changes
Bugfixes
Verification
Linked Issues
rancher/rke2#897
#5442
User-Facing Change
Further Comments