Remove go-powershell dead dependency #5777
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Derek Nola <derek.nola@suse.com>
|
Would like @phillipsj or @rosskirkpat to sign off on this as for some reason I remember this being Windows related. |
phillipsj
approved these changes
Jun 28, 2022
|
Looks like it originally came from an old Flannel update: There are a few custom patches that we've added on the trunk branch: https://github.com/k3s-io/go-powershell/commits/trunk - can we confirm that none of these are needed any longer? |
|
Looking back to what pulled this in at the time it was added, it appears that older versions of flannel used |
brandond
approved these changes
Jun 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Derek Nola derek.nola@suse.com
Proposed Changes
We don't use this dependency and it is a legacy from the transition from rancher to k3s-io
Types of Changes
go.mod cleanup
Verification
makeLinked Issues
#5775
User-Facing Change
Further Comments