Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Release-1.23] Add Secrets Encryption to CriticalArgs #6447

Merged
merged 1 commit into from Nov 4, 2022
Merged

[Release-1.23] Add Secrets Encryption to CriticalArgs #6447

merged 1 commit into from Nov 4, 2022

Conversation

dereknola
Copy link
Contributor

@dereknola dereknola commented Nov 4, 2022 •
edited by brandond

Backport of #6409

Linked Issues

#6450

User-Facing Change

K3s now indicates specifically which cluster-level configuration flags are out of sync when critical configuration differs between server nodes.

Further Comments

@dereknola
Add Secrets Encryption to CriticalArgs (k3s-io#6409)
2f93b38 
* Add EncryptSecrets to Critical Control Args
* use deep comparison to extract differences

Signed-off-by: Derek Nola <derek.nola@suse.com>

Signed-off-by: Derek Nola <derek.nola@suse.com>
@dereknola dereknola requested a review from a team as a code owner November 4, 2022 17:45
@brandond
Copy link
Contributor

brandond commented Nov 4, 2022

Postgres conformance failures appear to be a flake.

[PARALLEL-postgres] [Fail] [sig-node] Pods [It] should run through the lifecycle of Pods and PodStatus [Conformance] 
[PARALLEL-postgres] /workspace/src/k8s.io/kubernetes/_output/dockerized/go/src/k8s.io/kubernetes/test/e2e/common/node/pods.go:1052
[PARALLEL-postgres] 
[PARALLEL-postgres] [Fail] [sig-network] Proxy version v1 [It] A set of valid responses are returned for both pod and service ProxyWithPath [Conformance] 
[PARALLEL-postgres] /workspace/src/k8s.io/kubernetes/_output/dockerized/go/src/k8s.io/kubernetes/test/e2e/network/proxy.go:314

@dereknola dereknola merged commit 2ac863c into k3s-io:release-1.23 Nov 4, 2022
@dereknola dereknola deleted the critical_123 branch November 7, 2022 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brandond brandond brandond approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dereknola @brandond