Remove deprecated flags in v1.26 #6574
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dereknola
force-pushed
the
remove_deprecated_126
branch
from
fbc3e52
to
62b365c
Compare
briandowns
approved these changes
Nov 30, 2022
dereknola
force-pushed
the
remove_deprecated_126
branch
from
ff6eed3
to
8bcdab7
Compare
matttrach
approved these changes
Dec 2, 2022
Signed-off-by: Derek Nola <derek.nola@suse.com>
Signed-off-by: Derek Nola <derek.nola@suse.com>
Signed-off-by: Derek Nola <derek.nola@suse.com>
Signed-off-by: Derek Nola <derek.nola@suse.com>
Signed-off-by: Derek Nola <derek.nola@suse.com>
Signed-off-by: Derek Nola <derek.nola@suse.com>
Signed-off-by: Derek Nola <derek.nola@suse.com>
Signed-off-by: Derek Nola <derek.nola@suse.com>
dereknola
force-pushed
the
remove_deprecated_126
branch
from
8bcdab7
to
8faf0cb
Compare
brandond
approved these changes
Dec 5, 2022
dereknola
changed the title
|
This solves also #6440 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
For 1.26 we are ready to take the next step with our deprecated flags. The following have been completely removed.
And
wireguardbackend for flannel has been converted to a fatal error. It will be completely removed in 1.27Types of Changes
Flag deprecation
Verification
Attempt to start a server with:
Ensure that k3s complains about a nonexistent flag
Attempt to start the server with:
flannel-backend=wireguardEnsure that k3s complains with a fatal error and details how to migrate to the native wireguard.
Testing
Linked Issues
#6333
User-Facing Change
Further Comments