Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RIP Codespell #6701

Merged
merged 3 commits into from Jan 12, 2023
Merged

RIP Codespell #6701

merged 3 commits into from Jan 12, 2023

Conversation

cwayne18
Copy link
Collaborator

@cwayne18 cwayne18 commented Jan 5, 2023

Not really relevant to check for spelling issues since docs are in a separate castle

@cwayne18
RIP Codespell
4575dbb 
Signed-off-by: Chris Wayne <cwayne18@gmail.com>
@cwayne18 cwayne18 requested a review from a team as a code owner January 5, 2023 21:06
@briandowns
Copy link
Contributor

Also need to remove:

k3s/Dockerfile.test

Lines 30 to 31 in 3310c04

chmod a+x /usr/local/bin/kubectl; \
pip install codespell

@cwayne18
Remove .codepsellignore file
e5a8f6b 
Signed-off-by: Chris Wayne <cwayne18@gmail.com>
@cwayne18
Address review comments
51eba62 
Signed-off-by: Chris Wayne <cwayne18@gmail.com>
@cwayne18
Copy link
Collaborator Author

cwayne18 commented Jan 6, 2023

Also need to remove:

k3s/Dockerfile.test

Lines 30 to 31 in 3310c04

chmod a+x /usr/local/bin/kubectl; \
pip install codespell

ah good catch thank you -- fixed

@dereknola dereknola merged commit 3cafc8e into k3s-io:master Jan 12, 2023
@cguertin14 cguertin14 mentioned this pull request Jan 28, 2023
Merged
@cwayne18 cwayne18 deleted the kill-spell branch May 9, 2023 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brandond brandond brandond approved these changes

@briandowns briandowns briandowns approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@cwayne18 @briandowns @brandond @dereknola