Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-1.23] Fix issue with servicelb startup failure when validating webhooks block creation #6921

Merged
merged 2 commits into from Feb 10, 2023
Merged

[release-1.23] Fix issue with servicelb startup failure when validating webhooks block creation #6921

merged 2 commits into from Feb 10, 2023

Conversation

brandond
Copy link
Contributor

@brandond brandond commented Feb 7, 2023

Proposed Changes

Check for existing resources before creating them; prevents errors when starting with fail-closed webhooks

Also, use panic instead of Fatalf so that the CloudControllerManager rescue can handle the error

Types of Changes

bugfix

Verification

See linked issue

Testing

Linked Issues

User-Facing Change

The embedded cloud controller manager will no longer attempt to unconditionally re-create its namespace and serviceaccount on startup. This resolves an issue that could cause a deadlocked cluster when fail-closed webhooks are in use.

Further Comments

@brandond brandond requested a review from a team as a code owner February 7, 2023 22:07
@brandond
Check for existing resources before creating them
3ced893 
Prevents errors when starting with fail-closed webhooks

Also, use panic instead of Fatalf so that the CloudControllerManager rescue can handle the error

Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
@brandond
go generate
ce8b1c9 
Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
@brandond brandond force-pushed the fix_servicelb_webhook_release-1.23 branch 2 times, most recently from 7c7f85d to ce8b1c9 Compare February 10, 2023 02:01
@brandond brandond merged commit fa2ca3e into k3s-io:release-1.23 Feb 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briandowns briandowns briandowns approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@brandond @briandowns