Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added install functions for runit system. #7133

Closed
wants to merge 1 commit into from

Conversation

NeonFXFusion
Copy link

Proposed Changes

I have added functions installing k3s on systems running runit as their init system.

Types of Changes

New feature to the install script

Verification

Load up any machine running runit as an init system (I have tested it on Artix Linux running runit)

Testing

No. Additional changes are welcome to add a Vagrantfile to test it.

Linked Issues

User-Facing Change

NONE

Further Comments

@NeonFXFusion NeonFXFusion requested a review from a team as a code owner March 22, 2023 09:14
Signed-off-by: NeonFXFusion <neon.uvled@gmail.com>
Comment on lines +879 to +881
mountpoint -q /sys/fs/cgroup/systemd || {
mkdir -p /sys/fs/cgroup/systemd;
mount -t cgroup -o none,name=systemd cgroup /sys/fs/cgroup/systemd;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is interesting, why is it necessary to spoof the systemd cgroups? We don't do this for openrc.

Copy link
Author

@NeonFXFusion NeonFXFusion Mar 24, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dont know if it is explicitly required for all the functions but afik in the case of docker, docker and runsvdir don't quite agree on what each signal means and there may be some incompatibilities with how docker handles cgroups, which is why the official docker-runit package on Artix also uses this approach.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't use docker though, we use containerd. Does K3s work properly without this? It's not something I've ever seen before.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My bad I should of worded it differently, I will test it without the systemd spoofing as I don't know if its actually required.

@dereknola
Copy link
Contributor

@NeonFXFusion Is this PR still relevant?

@NeonFXFusion
Copy link
Author

I dont think so, either way it would be easier to close this PR and open a new one if I get to adding the runit functions again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants