Add aarch64 page size check to k3s check-config
#7298
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Derek Nola <derek.nola@suse.com>
brandond
approved these changes
Apr 17, 2023
|
I guess we don't need this since we fixed k3s-root. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Adds a check on arm64 architectures for a 4k page size. K3s does not support 64K or other page sizes on arm.
Types of Changes
Verification
Checked that it passes on a pi4 running Raspberry OS 64 bit. I don't have easy access to a non 4k OS to check for failure.
No change to x86_64 or other architectures
Testing
Linked Issues
#7288
User-Facing Change
Further Comments