Add integration tests for etc-snapshot server flags and refactor /tests/integration/integration.go/K3sStartServer #7300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dereknola
requested changes
Apr 17, 2023
osodracnai
force-pushed
the
etcdsnapshot-integration-test
branch
3 times, most recently
from
7df5064
to
1ac4c84
Compare
dereknola
approved these changes
Apr 18, 2023
brandond
reviewed
Apr 18, 2023
…ts/integration/integration.go/K3sStartServer This adds integration tests for the following flags: "--etcd-snapshot-name","--etcd-snapshot-dir","--etcd-snapshot-retention","--etcd-snapshot-schedule-cron" and "--etcd-snapshot-compress". It also refactors K3sStartServer to stop applying strings.Fields() into inputArgs, so it can accept arguments that have space in their definition. Signed-off-by: Ian Cardoso <osodracnai@gmail.com>
osodracnai
force-pushed
the
etcdsnapshot-integration-test
branch
from
1ac4c84
to
dbd006f
Compare
brandond
approved these changes
Apr 19, 2023
osodracnai
added a commit
to osodracnai/k3s
that referenced
this pull request
Apr 28, 2023
…ts/integration/integration.go/K3sStartServer (k3s-io#7300) This adds integration tests for the following flags: "--etcd-snapshot-name","--etcd-snapshot-dir","--etcd-snapshot-retention","--etcd-snapshot-schedule-cron" and "--etcd-snapshot-compress". It also refactors K3sStartServer to stop applying strings.Fields() into inputArgs, so it can accept arguments that have space in their definition. Signed-off-by: Ian Cardoso <osodracnai@gmail.com> (cherry picked from commit 1ac03aa)
osodracnai
added a commit
to osodracnai/k3s
that referenced
this pull request
Apr 28, 2023
…ts/integration/integration.go/K3sStartServer (k3s-io#7300) This adds integration tests for the following flags: "--etcd-snapshot-name","--etcd-snapshot-dir","--etcd-snapshot-retention","--etcd-snapshot-schedule-cron" and "--etcd-snapshot-compress". It also refactors K3sStartServer to stop applying strings.Fields() into inputArgs, so it can accept arguments that have space in their definition. Signed-off-by: Ian Cardoso <osodracnai@gmail.com> (cherry picked from commit 1ac03aa)
osodracnai
added a commit
to osodracnai/k3s
that referenced
this pull request
Apr 28, 2023
…ts/integration/integration.go/K3sStartServer (k3s-io#7300) This adds integration tests for the following flags: "--etcd-snapshot-name","--etcd-snapshot-dir","--etcd-snapshot-retention","--etcd-snapshot-schedule-cron" and "--etcd-snapshot-compress". It also refactors K3sStartServer to stop applying strings.Fields() into inputArgs, so it can accept arguments that have space in their definition. Signed-off-by: Ian Cardoso <osodracnai@gmail.com> (cherry picked from commit 1ac03aa)
osodracnai
added a commit
that referenced
this pull request
May 2, 2023
…ts/integration/integration.go/K3sStartServer (#7300) This adds integration tests for the following flags: "--etcd-snapshot-name","--etcd-snapshot-dir","--etcd-snapshot-retention","--etcd-snapshot-schedule-cron" and "--etcd-snapshot-compress". It also refactors K3sStartServer to stop applying strings.Fields() into inputArgs, so it can accept arguments that have space in their definition. Signed-off-by: Ian Cardoso <osodracnai@gmail.com> (cherry picked from commit 1ac03aa)
osodracnai
added a commit
that referenced
this pull request
May 2, 2023
…ts/integration/integration.go/K3sStartServer (#7300) This adds integration tests for the following flags: "--etcd-snapshot-name","--etcd-snapshot-dir","--etcd-snapshot-retention","--etcd-snapshot-schedule-cron" and "--etcd-snapshot-compress". It also refactors K3sStartServer to stop applying strings.Fields() into inputArgs, so it can accept arguments that have space in their definition. Signed-off-by: Ian Cardoso <osodracnai@gmail.com> (cherry picked from commit 1ac03aa)
osodracnai
added a commit
that referenced
this pull request
May 2, 2023
…ts/integration/integration.go/K3sStartServer (#7300) (#7377) This adds integration tests for the following flags: "--etcd-snapshot-name","--etcd-snapshot-dir","--etcd-snapshot-retention","--etcd-snapshot-schedule-cron" and "--etcd-snapshot-compress". It also refactors K3sStartServer to stop applying strings.Fields() into inputArgs, so it can accept arguments that have space in their definition. Signed-off-by: Ian Cardoso <osodracnai@gmail.com> (cherry picked from commit 1ac03aa)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
This adds integration tests for the following flags: "--etcd-snapshot-name","--etcd-snapshot-dir","--etcd-snapshot-retention","--etcd-snapshot-schedule-cron" and "--etcd-snapshot-compress". It also refactors K3sStartServer to receive as argument a string slice instead of a variadic arg and stop applying strings.Fields() into inputArgs, so it can accept arguments that have space in their definition.
Types of Changes
Verification
Testing
sudo -E env "PATH=$PATH" go test ./tests/integration/...Linked Issues
#6057
User-Facing Change
Further Comments