Create CRDs with schema #7308
Merged
Create CRDs with schema #7308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandond
force-pushed
the
fix-crd-schema
branch
2 times, most recently
from
7e26671
to
4574e35
Compare
brandond
force-pushed
the
fix-crd-schema
branch
from
4574e35
to
26c74d3
Compare
Fixes an issue where CRDs were being created without schema, allowing resources with invalid content to be created, later stalling the controller ListWatch event channel when the invalid resources could not be deserialized. This also requires moving Addon GVK tracking from a status field to an annotation, as the GroupVersionKind type has special handling internal to Kubernetes that prevents it from being serialized to the CRD when schema validation is enabled. Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
brandond
force-pushed
the
fix-crd-schema
branch
from
26c74d3
to
14add82
Compare
briandowns
approved these changes
Apr 19, 2023
dereknola
approved these changes
Apr 19, 2023
galal-hussein
approved these changes
Apr 19, 2023
This was referenced May 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Fixes an issue where CRDs were being created without schema, allowing resources with invalid content to be created, later stalling the controller ListWatch event channel when the invalid resources could not be deserialized, as discussed at k3s-io/helm-controller#172
This matches the behavior observed by the helm-controller when run standalone:
https://github.com/k3s-io/helm-controller/blob/a14e7f478f924eeb79df9e8e3c102962dab55091/main.go#L58
This also requires moving Addon GVK tracking from a status field to an annotation, as the GroupVersionKind type has special handling internal to Kubernetes that prevents it from being serialized to the resource when schema validation is enabled.
Currently blocked on a Wrangler bug that breaks IntOrString fields:Types of Changes
bugfix
Verification
See linked issue
Testing
Linked Issues
HelmChartSpec.items.spec.setcan stall controller queue processing helm-controller#172User-Facing Change
Further Comments