Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Release-1.24] add format command on Makefile #7764

Merged
merged 1 commit into from Jun 14, 2023

Conversation

osodracnai
Copy link
Contributor

@osodracnai osodracnai commented Jun 12, 2023

Proposed Changes

backport for #7437
closes #7765

Types of Changes

Verification

Testing

Linked Issues

User-Facing Change


Further Comments

This commit adds the format command to make it easier to be compliant to golangci-lint issues

Signed-off-by: Ian Cardoso <osodracnai@gmail.com>
@osodracnai osodracnai requested a review from a team as a code owner June 12, 2023 20:10
@osodracnai osodracnai self-assigned this Jun 12, 2023
@osodracnai osodracnai linked an issue Jun 12, 2023 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Jun 13, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (38e0baa) 10.12% compared to head (25ecb86) 10.12%.

Additional details and impacted files
@@              Coverage Diff              @@
##           release-1.24    #7764   +/-   ##
=============================================
  Coverage         10.12%   10.12%           
=============================================
  Files               149      149           
  Lines             10790    10790           
=============================================
  Hits               1092     1092           
  Misses             9473     9473           
  Partials            225      225           
Flag Coverage Δ
unittests 10.12% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@osodracnai osodracnai merged commit 362ae11 into k3s-io:release-1.24 Jun 14, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Release-1.24] add format command on Makefile
3 participants