Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ADR on secrets encryption v3 #7938

Merged
merged 3 commits into from Jul 31, 2023
Merged

ADR on secrets encryption v3 #7938

merged 3 commits into from Jul 31, 2023

Conversation

dereknola
Copy link
Contributor

Signed-off-by: Derek Nola derek.nola@suse.com

Proposed Changes

Types of Changes

Verification

Testing

Linked Issues

User-Facing Change


Further Comments

Signed-off-by: Derek Nola <derek.nola@suse.com>
Signed-off-by: Derek Nola <derek.nola@suse.com>
Copy link
Contributor

@brandond brandond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

Signed-off-by: Derek Nola <derek.nola@suse.com>
@dereknola dereknola marked this pull request as ready for review July 31, 2023 17:20
@dereknola dereknola requested a review from a team as a code owner July 31, 2023 17:20
@dereknola dereknola merged commit 946c8ea into k3s-io:master Jul 31, 2023
2 checks passed
eltociear pushed a commit to eltociear/k3s that referenced this pull request Aug 1, 2023
* ADR on secrets encryption v3

Signed-off-by: Derek Nola <derek.nola@suse.com>

* Update adr based off design meeting discussion

Signed-off-by: Derek Nola <derek.nola@suse.com>

* Update with acceptance

Signed-off-by: Derek Nola <derek.nola@suse.com>

---------

Signed-off-by: Derek Nola <derek.nola@suse.com>
Signed-off-by: Ikko Eltociear Ashimine <eltociear@gmail.com>
@dereknola dereknola deleted the se_v3 branch August 1, 2023 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants