[Release-1.26] Generation of certs and keys for etcd gated if etcd is disabled #7944
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d. (k3s-io#6998) Problem: When support for etcd was added in 3957142, generation of certificates and keys for etcd was not gated behind use of managed etcd. Keys are generated and distributed across servers even if managed etcd is not enabled. Solution: Allow generation of certificates and keys only if managed etc is enabled. Check config.DisableETCD flag. Signed-off-by: Bartossh <lenartconsulting@gmail.com> Signed-off-by: Derek Nola <derek.nola@suse.com>
dereknola
force-pushed
the
etcd_ca_skip_126
branch
from
7d9a831
to
28864b2
Compare
osodracnai
approved these changes
Jul 11, 2023
vitorsavian
approved these changes
Jul 11, 2023
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## release-1.26 #7944 +/- ##
================================================
- Coverage 10.00% 10.00% -0.01%
================================================
Files 150 150
Lines 10928 10930 +2
================================================
Hits 1093 1093
- Misses 9610 9611 +1
- Partials 225 226 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Backport #6998 to 1.26
Linked Issues
#7943
User-Facing Change
Further Comments