Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added advertise address integration test #8344

Merged

Conversation

vitorsavian
Copy link
Contributor

Proposed Changes

Integration test for ---advertise-address flag

Types of Changes

Integration test

Verification

sudo go test ./tests/integration/advertise/... -run Integration

Testing

Linked Issues

User-Facing Change


Further Comments

@vitorsavian vitorsavian requested a review from a team as a code owner September 12, 2023 16:21
Copy link
Contributor

@dereknola dereknola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no need to make a individual test for a single flag, this is why we have the startup test https://github.com/k3s-io/k3s/blob/master/tests/integration/startup/startup_int_test.go#L84. You should expand the existing testlet which is already creating and cleaning up dummy interfaces.

Signed-off-by: Vitor Savian <vitor.savian@suse.com>
@vitorsavian vitorsavian force-pushed the advertise-address-integration-test branch from 2aee59d to bdfc4d3 Compare September 25, 2023 18:35
@codecov
Copy link

codecov bot commented Sep 26, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (cae8b2b) 44.66% compared to head (7702d49) 51.46%.
Report is 9 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8344      +/-   ##
==========================================
+ Coverage   44.66%   51.46%   +6.79%     
==========================================
  Files         143      143              
  Lines       14746    15229     +483     
==========================================
+ Hits         6587     7837    +1250     
+ Misses       7119     6171     -948     
- Partials     1040     1221     +181     
Flag Coverage Δ
e2etests 48.63% <100.00%> (?)
inttests 44.73% <66.66%> (+2.77%) ⬆️
unittests 19.84% <33.33%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
pkg/daemons/executor/executor.go 57.81% <ø> (ø)
pkg/etcd/etcd.go 44.88% <100.00%> (+9.20%) ⬆️

... and 49 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants