Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Release-1.26] Added error when cluster reset while using server flag #8456

Conversation

vitorsavian
Copy link
Contributor

@vitorsavian vitorsavian commented Sep 26, 2023

Proposed Changes

Backport
Handle when the user tries to --cluster-reset when using the --server flag

Types of Changes

Backport
Handling Error

Verification

k3s server --server 11.22.33.44 --cluster-reset

Testing

Linked Issues

User-Facing Change

The user will receive a error when --cluster-reset with the --server flag

Further Comments

Signed-off-by: Vitor Savian <vitor.savian@suse.com>
@vitorsavian vitorsavian requested a review from a team as a code owner September 26, 2023 18:17
@codecov
Copy link

codecov bot commented Sep 26, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (2fc9a40) 19.47% compared to head (fbf9ce4) 19.48%.
Report is 5 commits behind head on release-1.26.

Additional details and impacted files
@@              Coverage Diff              @@
##           release-1.26    #8456   +/-   ##
=============================================
  Coverage         19.47%   19.48%           
=============================================
  Files                83       83           
  Lines              5606     5605    -1     
=============================================
  Hits               1092     1092           
+ Misses             4288     4287    -1     
  Partials            226      226           
Flag Coverage Δ
unittests 19.48% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vitorsavian vitorsavian merged commit 3dd36d2 into k3s-io:release-1.26 Sep 27, 2023
19 checks passed
@vitorsavian vitorsavian deleted the add-cluster-reset-error-server-flag-release-1.26 branch October 18, 2023 00:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants