Force umount for NFS mount (like with longhorn)

[smutel]

Proposed Changes

When using k3s with storage system like longhorn, the uninstall script hangs when trying to unmount filesystems managed by NFS.

Types of Changes

Bugfix

Verification

• Install k3s with longhorn
• Create a volume
• Uninstall it

Testing

Not sure that the install.sh is covered by tests right now.

Linked Issues

• Uninstall hangs with NFS mount points (using longhorn for example) #8520

User-Facing Change

[brandond]

Thanks for the PR! If you change the install script, you need to update the install script checksum file as well.

[smutel]

Done.

[dereknola]

@smutel Thanks for the PR. To follow CNCF Guidelines we require that all commits be signed. See https://github.com/k3s-io/k3s/pull/8521/checks?check_run_id=17890940938 for instructions on recommit your changes with a signed commit.

Once DCO passes, we can get this PR in. We are currently in code freeze, so it won't be till likely next week that this gets merged.

Also don't worry about s390x failures in CI, its a known bug right now.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (bbafb86) 47.12% compared to head (c643f0a) 49.36%.

❗ Current head c643f0a differs from pull request most recent head 82eb681. Consider uploading reports for the commit 82eb681 to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #8521      +/-   ##
==========================================
+ Coverage   47.12%   49.36%   +2.23%     
==========================================
  Files         148      148              
  Lines       15674    15674              
==========================================
+ Hits         7387     7737     +350     
+ Misses       7089     6698     -391     
- Partials     1198     1239      +41     

Flag	Coverage Δ
e2etests	46.88% <ø> (?)
inttests	41.09% <ø> (-3.52%)	⬇️
unittests	17.87% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 44 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[smutel]

Rebase done. Could we merge this PR ? I already rebase this PR 3 times due to sha256 on install.sh.

[rds13]

👍

[brandond]

s390x flaked; merging

[DanielJuravski]

Is there a reason why this commit wasn't cherry-picked to 1.26?

[caroline-suse-rancher]

@DanielJuravski We don't backport changes to the install script, as it's unnecessary. See that noted in the associated 1.26 issue - #8856