Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v1.27] System agent push tags fix #8569

Merged
merged 2 commits into from Oct 6, 2023

Conversation

johnatasr
Copy link
Contributor

@johnatasr johnatasr commented Oct 6, 2023

Proposed Changes

  • change cURL to push tags with a new created token
  • add in drone step the new token as a secret

Types of Changes

  • CI

Verification

Testing

Linked Issues

https://github.com/rancherlabs/eio/issues/1643

User-Facing Change


Further Comments

Signed-off-by: Johnatas <johnatasr@hotmail.com>
Signed-off-by: Johnatas <johnatasr@hotmail.com>
@johnatasr johnatasr marked this pull request as ready for review October 6, 2023 17:54
@johnatasr johnatasr requested a review from a team as a code owner October 6, 2023 17:54
@codecov
Copy link

codecov bot commented Oct 6, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (c928fb0) 45.60% compared to head (83c0817) 51.74%.

Additional details and impacted files
@@               Coverage Diff                @@
##           release-1.27    #8569      +/-   ##
================================================
+ Coverage         45.60%   51.74%   +6.13%     
================================================
  Files               144      144              
  Lines             14611    14611              
================================================
+ Hits               6664     7561     +897     
+ Misses             6867     5874     -993     
- Partials           1080     1176      +96     
Flag Coverage Δ
e2etests 49.12% <ø> (?)
inttests 44.67% <ø> (+2.54%) ⬆️
unittests 19.90% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 46 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@johnatasr johnatasr merged commit 6c2a7cb into k3s-io:release-1.27 Oct 6, 2023
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants