Add etcd-only/control-plane-only server test and fix control-plane-only server crash #8638
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandond
force-pushed
the
fix-disable-etcd
branch
from
58361ff
to
18b4314
Compare
briandowns
approved these changes
Oct 13, 2023
dereknola
approved these changes
Oct 13, 2023
brandond
force-pushed
the
fix-disable-etcd
branch
2 times, most recently
from
f09fe5c
to
a67424b
Compare
Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
brandond
force-pushed
the
fix-disable-etcd
branch
from
a67424b
to
b2bebd1
Compare
This was referenced Nov 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Add a test, fix what's broken
Types of Changes
bugfix, test
Verification
Testing
Adds a test
Linked Issues
User-Facing Change
Further Comments