Disable helm CRD installation for disable-helm-controller #8702
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The NewContext package requires config as input which would require all third-party callers to update when the new go module is published. This change only affects the behaviour of installation of helm CRDs. Existing helm crds installed in a cluster would not be removed when disable-helm-controller flag is set on the server. Addresses k3s-io#8701 Signed-off-by: Harsimran Singh Maan <maan.harry@gmail.com>
brandond
requested changes
Oct 19, 2023
Signed-off-by: Harsimran Singh Maan <maan.harry@gmail.com>
Signed-off-by: Harsimran Singh Maan <maan.harry@gmail.com>
brandond
approved these changes
Oct 19, 2023
|
LGTM! We can squash when merging. |
|
Hi @brandond, lemme know if this require any further work. Feel free to merge it |
|
You're all set.We're in code freeze pending release of last week's patches. We will merge things again once the releases are out. |
dereknola
approved these changes
Nov 15, 2023
|
arm and s390x are flaking; merging |
brandond
pushed a commit
to brandond/k3s
that referenced
this pull request
Nov 16, 2023
* Disable helm CRD installation for disable-helm-controller
The NewContext package requires config as input which would
require all third-party callers to update when the new go module
is published.
This change only affects the behaviour of installation of helm
CRDs. Existing helm crds installed in a cluster would not be removed
when disable-helm-controller flag is set on the server.
Addresses k3s-io#8701
* address review comments
* remove redundant check
Signed-off-by: Harsimran Singh Maan <maan.harry@gmail.com>
(cherry picked from commit abc2efd)
Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
brandond
pushed a commit
to brandond/k3s
that referenced
this pull request
Nov 16, 2023
* Disable helm CRD installation for disable-helm-controller
The NewContext package requires config as input which would
require all third-party callers to update when the new go module
is published.
This change only affects the behaviour of installation of helm
CRDs. Existing helm crds installed in a cluster would not be removed
when disable-helm-controller flag is set on the server.
Addresses k3s-io#8701
* address review comments
* remove redundant check
Signed-off-by: Harsimran Singh Maan <maan.harry@gmail.com>
(cherry picked from commit abc2efd)
Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
brandond
pushed a commit
to brandond/k3s
that referenced
this pull request
Nov 16, 2023
* Disable helm CRD installation for disable-helm-controller
The NewContext package requires config as input which would
require all third-party callers to update when the new go module
is published.
This change only affects the behaviour of installation of helm
CRDs. Existing helm crds installed in a cluster would not be removed
when disable-helm-controller flag is set on the server.
Addresses k3s-io#8701
* address review comments
* remove redundant check
Signed-off-by: Harsimran Singh Maan <maan.harry@gmail.com>
(cherry picked from commit abc2efd)
Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
brandond
pushed a commit
that referenced
this pull request
Nov 16, 2023
* Disable helm CRD installation for disable-helm-controller
The NewContext package requires config as input which would
require all third-party callers to update when the new go module
is published.
This change only affects the behaviour of installation of helm
CRDs. Existing helm crds installed in a cluster would not be removed
when disable-helm-controller flag is set on the server.
Addresses #8701
* address review comments
* remove redundant check
Signed-off-by: Harsimran Singh Maan <maan.harry@gmail.com>
(cherry picked from commit abc2efd)
Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
brandond
pushed a commit
that referenced
this pull request
Nov 16, 2023
* Disable helm CRD installation for disable-helm-controller
The NewContext package requires config as input which would
require all third-party callers to update when the new go module
is published.
This change only affects the behaviour of installation of helm
CRDs. Existing helm crds installed in a cluster would not be removed
when disable-helm-controller flag is set on the server.
Addresses #8701
* address review comments
* remove redundant check
Signed-off-by: Harsimran Singh Maan <maan.harry@gmail.com>
(cherry picked from commit abc2efd)
Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
brandond
pushed a commit
that referenced
this pull request
Nov 16, 2023
* Disable helm CRD installation for disable-helm-controller
The NewContext package requires config as input which would
require all third-party callers to update when the new go module
is published.
This change only affects the behaviour of installation of helm
CRDs. Existing helm crds installed in a cluster would not be removed
when disable-helm-controller flag is set on the server.
Addresses #8701
* address review comments
* remove redundant check
Signed-off-by: Harsimran Singh Maan <maan.harry@gmail.com>
(cherry picked from commit abc2efd)
Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
This was referenced Dec 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The NewContext package requires config as input which would require all third-party callers to update when the new go module is published.
This change only affects the behaviour of installation of helm CRDs. Existing helm crds installed in a cluster would not be removed when disable-helm-controller flag is set on the server.
Addresses #8701
Proposed Changes
Disable helm CRD installation for disable-helm-controller
Types of Changes
Breaking Change (for sdk) not for k3s service
Verification
Testing
Linked Issues
User-Facing Change
Further Comments
Closes #8701