Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add warning for removal of multiclustercidr flag #8758

Merged
merged 1 commit into from Nov 13, 2023

Conversation

galal-hussein
Copy link
Contributor

Proposed Changes

Remove k3s flag for multiclustercidr

Types of Changes

Since the multiclustercidr alpha support has been removed upstream, we need to remove its support from k3s

Verification

Testing

Linked Issues

User-Facing Change


Further Comments

@galal-hussein galal-hussein requested a review from a team as a code owner November 1, 2023 19:13
Copy link
Contributor

@dereknola dereknola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to remove the MulticlusterCIDR E2E test as well.

Copy link

codecov bot commented Nov 1, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (49411e7) 46.30% compared to head (374a91c) 48.27%.
Report is 11 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8758      +/-   ##
==========================================
+ Coverage   46.30%   48.27%   +1.96%     
==========================================
  Files         148      145       -3     
  Lines       15674    15675       +1     
==========================================
+ Hits         7258     7567     +309     
+ Misses       7265     6825     -440     
- Partials     1151     1283     +132     
Flag Coverage Δ
e2etests 46.97% <0.00%> (?)
inttests 43.54% <0.00%> (-0.24%) ⬇️
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
pkg/cli/server/server.go 61.92% <0.00%> (+1.79%) ⬆️

... and 59 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: galal-hussein <hussein.galal.ahmed.11@gmail.com>
@galal-hussein galal-hussein changed the title Remove multiclustercidr flag Add warning for removal of multiclustercidr flag Nov 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants