Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Release-1.27] Fix SystemdCgroup in templates_linux.go #8765

Merged
merged 1 commit into from Nov 2, 2023

Conversation

dereknola
Copy link
Contributor

@dereknola dereknola commented Nov 2, 2023

Proposed Changes

Types of Changes

Verification

Testing

Linked Issues

#8770

User-Facing Change

Fixed an issue with identifying additional container runtimes

Further Comments

Signed-off-by: Derek Nola <derek.nola@suse.com>
@dereknola dereknola requested a review from a team as a code owner November 2, 2023 17:25
Copy link

codecov bot commented Nov 2, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b6f2301) 46.24% compared to head (88bcf32) 47.75%.

Additional details and impacted files
@@               Coverage Diff                @@
##           release-1.27    #8765      +/-   ##
================================================
+ Coverage         46.24%   47.75%   +1.50%     
================================================
  Files               149      149              
  Lines             15583    15583              
================================================
+ Hits               7207     7441     +234     
+ Misses             7224     6920     -304     
- Partials           1152     1222      +70     
Flag Coverage Δ
e2etests 47.08% <ø> (?)
inttests 39.34% <ø> (-4.37%) ⬇️
unittests 17.88% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
pkg/agent/templates/templates_linux.go 62.50% <ø> (ø)

... and 50 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dereknola dereknola merged commit 40ee272 into k3s-io:release-1.27 Nov 2, 2023
15 checks passed
@dereknola dereknola deleted the nvidiacfgfix_127 branch November 6, 2023 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants