Remove depends_on for e2e step; fix cert rotate e2e #8906
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reverts part of the change from 7d38b4a Pipeline dependencies are apparently broken, and the e2e pipeline has been getting skipped whenever any other pipeline fails. Ex: https://drone-pr.k3s.io/k3s-io/k3s/7853 Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
galal-hussein
approved these changes
Nov 17, 2023
matttrach
approved these changes
Nov 17, 2023
dereknola
approved these changes
Nov 17, 2023
Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
brandond
force-pushed
the
no-e2e-depends
branch
from
fd02eee
to
9324466
Compare
This was referenced Dec 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Revert e2e pipeline depends_on change
Reverts part of the change from 7d38b4a
Pipeline dependencies are apparently broken, and the e2e pipeline has been getting skipped whenever any other pipeline fails. Ex: https://drone-pr.k3s.io/k3s-io/k3s/7853
Fix flakey dynamic-cert.json in cert rotation e2e test
Types of Changes
CI
Verification
Testing
Linked Issues
User-Facing Change
Further Comments