Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the OTHER etcd snapshot s3 log message that prints the wrong variable #8944

Merged
merged 1 commit into from Jan 4, 2024

Conversation

brandond
Copy link
Contributor

Proposed Changes

Fix the OTHER log message that prints the wrong variable

Types of Changes

bugfix

Verification

Check log message

Testing

Linked Issues

User-Facing Change

Further Comments

@brandond brandond requested a review from a team as a code owner November 22, 2023 20:02
@brandond brandond changed the title Fix the OTHER log message that prints the wrong variable Fix the OTHER etcd snapshot s3 log message that prints the wrong variable Nov 22, 2023
Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
Copy link

codecov bot commented Jan 4, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (08ccea5) 41.56% compared to head (a6b9b3d) 41.58%.

Files Patch % Lines
pkg/etcd/s3.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8944      +/-   ##
==========================================
+ Coverage   41.56%   41.58%   +0.01%     
==========================================
  Files         148      148              
  Lines       15946    15946              
==========================================
+ Hits         6628     6631       +3     
+ Misses       8189     8186       -3     
  Partials     1129     1129              
Flag Coverage Δ
inttests 38.80% <0.00%> (+0.01%) ⬆️
unittests 18.34% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants