Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump containerd/runc to v1.7.10-k3s1/v1.1.10 #8962

Merged
merged 1 commit into from Dec 9, 2023

Conversation

brandond
Copy link
Contributor

@brandond brandond commented Nov 28, 2023

Proposed Changes

Bump containerd/runc to v1.7.10-k3s1/v1.1.10

Types of Changes

version bump

Verification

Check version

Testing

Linked Issues

User-Facing Change

Further Comments

@brandond brandond requested a review from a team as a code owner November 28, 2023 23:59
@brandond brandond changed the title Bump containerd/runc to v1.7.9-k3s1/v1.1.10 [WIP] Bump containerd/runc to v1.7.9-k3s1/v1.1.10 Nov 29, 2023
@brandond brandond changed the title [WIP] Bump containerd/runc to v1.7.9-k3s1/v1.1.10 Bump containerd/runc to v1.7.9-k3s1/v1.1.10 Nov 29, 2023
Copy link

codecov bot commented Nov 29, 2023

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (3f23723) 46.74% compared to head (c68077d) 47.18%.
Report is 7 commits behind head on master.

❗ Current head c68077d differs from pull request most recent head 7fdfa5b. Consider uploading reports for the commit 7fdfa5b to get more accurate results

Files Patch % Lines
pkg/cgroups/cgroups_linux.go 53.33% 5 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8962      +/-   ##
==========================================
+ Coverage   46.74%   47.18%   +0.44%     
==========================================
  Files         150      147       -3     
  Lines       15837    12707    -3130     
==========================================
- Hits         7403     5996    -1407     
+ Misses       7232     5562    -1670     
+ Partials     1202     1149      -53     
Flag Coverage Δ
e2etests 47.18% <53.33%> (?)
inttests ?
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

}

func validateCgroupsV1() error {
cgroups, err := os.ReadFile("/proc/self/cgroup")
controllers, err := cgroupsv1.Default()
Copy link
Contributor Author

@brandond brandond Nov 29, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@brandond brandond changed the title Bump containerd/runc to v1.7.9-k3s1/v1.1.10 Bump containerd/runc to v1.7.10-k3s1/v1.1.10 Dec 8, 2023
Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
@brandond
Copy link
Contributor Author

brandond commented Dec 9, 2023

codecov missing keys; merging

@brandond brandond merged commit b9c288f into k3s-io:master Dec 9, 2023
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants