Dockerfile.dapper: set $HOME properly #9090
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`$HOME` refers to `$DAPPER_SOURCE`, which is set in the same expression and is thus not visible at the time of substitution. This problem is not immediately visible with Docker, Inc.'s docker merely because it resets an unset `$HOME` to `/root` (but still breaking the Go cache). Under podman, this problem is immediately visible because an unset `$HOME` remains unset and subsequently breaks the `go generate` invocation. Fixes k3s-io#9089. Signed-off-by: Ivan Shapovalov <intelfx@intelfx.name>
intelfx
force-pushed
the
work/dapperfile-fix-home
branch
from
bf93a75
to
18b1172
Compare
brandond
approved these changes
Dec 22, 2023
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #9090 +/- ##
==========================================
- Coverage 46.35% 41.62% -4.73%
==========================================
Files 148 148
Lines 15900 15900
==========================================
- Hits 7371 6619 -752
- Misses 7354 8151 +797
+ Partials 1175 1130 -45
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
dereknola
approved these changes
Dec 26, 2023
This was referenced Jan 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
$HOMErefers to$DAPPER_SOURCE, which is set in the same expression and is thus not visible at the time of substitution.This problem is not immediately visible with Docker, Inc.'s docker merely because it resets an unset
$HOMEto/root(but still breaking the Go cache). Under podman, this problem is immediately visible because an unset$HOMEremains unset and subsequently breaks thego generateinvocation.Types of Changes
Bug fix — build system
Verification
Run
make generateunder podmanTesting
N/A — build system
Linked Issues
make generatefails under podman due to unset$HOME, and is subtly broken under docker #9089User-Facing Change