Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Release-1.27] Etcd node is nil #9229

Merged
merged 1 commit into from Jan 12, 2024

Conversation

vitorsavian
Copy link
Contributor

@vitorsavian vitorsavian commented Jan 12, 2024

Added retry and changed nodes for

Proposed Changes

Types of Changes

Verification

Testing

Linked Issues

User-Facing Change


Further Comments

Signed-off-by: Vitor Savian <vitor.savian@suse.com>

Added retry and changed nodes for

Signed-off-by: Vitor Savian <vitor.savian@suse.com>
@vitorsavian vitorsavian requested a review from a team as a code owner January 12, 2024 19:51
Copy link

codecov bot commented Jan 12, 2024

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (373c680) 45.62% compared to head (55c20ce) 45.56%.

Files Patch % Lines
pkg/etcd/etcd.go 56.25% 4 Missing and 3 partials ⚠️
Additional details and impacted files
@@               Coverage Diff                @@
##           release-1.27    #9229      +/-   ##
================================================
- Coverage         45.62%   45.56%   -0.06%     
================================================
  Files               154      154              
  Lines             16415    16416       +1     
================================================
- Hits               7489     7480       -9     
- Misses             7707     7710       +3     
- Partials           1219     1226       +7     
Flag Coverage Δ
inttests 43.05% <56.25%> (-0.06%) ⬇️
unittests 14.58% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vitorsavian vitorsavian merged commit 5564a95 into k3s-io:release-1.27 Jan 12, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants