[release-1.28] Backports for 2024-01 k3s2 #9336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fix issue with bare host or IP as endpoint * Fix issue with localhost registries not defaulting to http. * Move the registry template prep to a separate function, and adds tests of that function so that we can ensure we're generating the correct content. Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
brandond
force-pushed
the
2024-01-k3s2-backports_release-1.28
branch
2 times, most recently
from
319a89e
to
5e3bc81
Compare
Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
brandond
force-pushed
the
2024-01-k3s2-backports_release-1.28
branch
from
5e3bc81
to
88cdfc7
Compare
vitorsavian
approved these changes
Feb 1, 2024
VestigeJ
approved these changes
Feb 1, 2024
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## release-1.28 #9336 +/- ##
================================================
- Coverage 48.88% 46.21% -2.67%
================================================
Files 154 154
Lines 16536 16604 +68
================================================
- Hits 8084 7674 -410
- Misses 7168 7699 +531
+ Partials 1284 1231 -53
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Backports:
Types of Changes
version bump, bugfix, backport
Verification
See linked PRs
Testing
Linked Issues
User-Facing Change
Further Comments