Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Release-1.28] Test_UnitApplyContainerdQoSClassConfigFileIfPresent #9440

Merged
merged 2 commits into from Feb 12, 2024

Conversation

dereknola
Copy link
Contributor

Backport #8945

Linked Issues

#9439

User-Facing Change


Further Comments

…ed) (k3s-io#8945)

Problem:
Function not tested.

Solution:
Unit test added.

Signed-off-by: Oliver Larsson <larsson.e.oliver@gmail.com>
@dereknola dereknola requested a review from a team as a code owner February 9, 2024 19:34
Signed-off-by: Derek Nola <derek.nola@suse.com>
Copy link

codecov bot commented Feb 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (dda9780) 49.30% compared to head (f898ce3) 46.05%.

Additional details and impacted files
@@               Coverage Diff                @@
##           release-1.28    #9440      +/-   ##
================================================
- Coverage         49.30%   46.05%   -3.25%     
================================================
  Files               154      154              
  Lines             16616    16620       +4     
================================================
- Hits               8192     7655     -537     
- Misses             7137     7731     +594     
+ Partials           1287     1234      -53     
Flag Coverage Δ
e2etests ?
inttests 42.87% <37.50%> (+0.82%) ⬆️
unittests 15.24% <93.75%> (+0.15%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dereknola dereknola merged commit 4586010 into k3s-io:release-1.28 Feb 12, 2024
15 checks passed
@dereknola dereknola deleted the qos_unit_128 branch February 12, 2024 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants