Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Release-1.26] Enable longer http timeout requests #9446

Merged
merged 1 commit into from Feb 12, 2024

Conversation

dereknola
Copy link
Contributor

Proposed Changes

Backport a portion of #9340, the parts not related to Secrets Encryption in 1.29

  • Enable Timeout modification on a HTTP request

Linked Issues

TBD

User-Facing Change


Further Comments

Signed-off-by: Derek Nola <derek.nola@suse.com>
@dereknola dereknola requested a review from a team as a code owner February 9, 2024 19:44
Copy link

codecov bot commented Feb 9, 2024

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (b5da7cf) 14.73% compared to head (cf6aeb0) 14.72%.

Files Patch % Lines
pkg/clientaccess/token.go 28.57% 5 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff                @@
##           release-1.26    #9446      +/-   ##
================================================
- Coverage         14.73%   14.72%   -0.01%     
================================================
  Files               115      115              
  Lines              8457     8461       +4     
================================================
  Hits               1246     1246              
- Misses             6961     6965       +4     
  Partials            250      250              
Flag Coverage Δ
unittests 14.72% <28.57%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dereknola dereknola merged commit e78053e into k3s-io:release-1.26 Feb 12, 2024
15 checks passed
@dereknola dereknola deleted the http_timeout_126 branch February 12, 2024 17:31
@dereknola
Copy link
Contributor Author

There is nothing to QA, the code here is not actually currently in use on older branches. Its exists to prevent cherry-pick conflicts in future PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants