Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix additional corner cases in registries handling #9556

Merged
merged 1 commit into from Mar 4, 2024

Conversation

brandond
Copy link
Contributor

@brandond brandond commented Feb 23, 2024

Proposed Changes

Fix additional corner cases in registries handling

  • Add support for explicit default endpoint (default endpoint address manually included in last position in endpoint list)
  • Add support for loading tls and credential config from wildcard entry.

Types of Changes

bugfix

Verification

See linked issue

Testing

yes

Linked Issues

User-Facing Change

Further Comments

Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
@brandond brandond requested a review from a team as a code owner February 23, 2024 00:52
Copy link

codecov bot commented Feb 23, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 13 lines in your changes are missing coverage. Please review.

Project coverage is 42.99%. Comparing base (fae0d99) to head (9964bef).

Files Patch % Lines
pkg/agent/containerd/config.go 80.00% 8 Missing and 5 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #9556      +/-   ##
==========================================
- Coverage   49.19%   42.99%   -6.20%     
==========================================
  Files         151      154       +3     
  Lines       13471    13541      +70     
==========================================
- Hits         6627     5822     -805     
- Misses       5506     6549    +1043     
+ Partials     1338     1170     -168     
Flag Coverage Δ
e2etests ?
inttests 39.42% <0.00%> (-0.08%) ⬇️
unittests 16.18% <80.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants