Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run Subset of Docker tests in GitHub Actions #9698

Merged
merged 3 commits into from Mar 8, 2024

Conversation

dereknola
Copy link
Contributor

@dereknola dereknola commented Mar 7, 2024

Proposed Changes

  • Convert a portion of the docker test currently running in Drone to running as part of the E2E GitHub Action
    Note: This PR only reduced the drone load for amd64. For arm64/arm architectures the tests will remain as is, as GitHub Actions do not yet exist for those architectures.
  • Fix flaky check on btrfs e2e test
  • Fix broken cache name for e2e vagrant boxes

Types of Changes

CI/Testing

Verification

Takes about 3 minutes off the Drone times... Not much, but every bit counts. Plus now the runners won't need pruning as much.
See https://github.com/dereknola/k3s/actions/runs/8193839495?pr=22, with the new matrices (as this PR won't run the new tests until commited to master for security reasons)
image

Linked Issues

TBD

User-Facing Change


Further Comments

Build image with new input option
Run most of the basic docker tests in E2E
Signed-off-by: Derek Nola <derek.nola@suse.com>
Signed-off-by: Derek Nola <derek.nola@suse.com>
Signed-off-by: Derek Nola <derek.nola@suse.com>
@dereknola dereknola requested a review from a team as a code owner March 7, 2024 23:59
Copy link

codecov bot commented Mar 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 46.35%. Comparing base (9bd4c8a) to head (074250d).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #9698      +/-   ##
==========================================
+ Coverage   43.59%   46.35%   +2.76%     
==========================================
  Files         151      154       +3     
  Lines       13543    13595      +52     
==========================================
+ Hits         5904     6302     +398     
+ Misses       6420     6076     -344     
+ Partials     1219     1217       -2     
Flag Coverage Δ
e2etests 38.95% <ø> (-0.01%) ⬇️
inttests 39.33% <ø> (-0.10%) ⬇️
unittests 16.15% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@@ -30,10 +30,10 @@ env:
jobs:
build:
uses: ./.github/workflows/build-k3s.yaml
test:
itest:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is the significance of the 'i'?

Copy link
Contributor

@brandond brandond Mar 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

short for integration?

jobs:
  itest:
    name: Integration Tests

The job key has no external significance, other than being able reference it as a dependency in the needs section of other jobs.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct. This tag is necessary for the structure but ultimately irrelevant because there are no further jobs in this workflow. I just kept seeing test over and over in the workflows, and I want to make it something slightly more descriptive.

@dereknola dereknola merged commit 364dfd8 into k3s-io:master Mar 8, 2024
26 checks passed
@dereknola dereknola mentioned this pull request Mar 18, 2024
14 tasks
@dereknola dereknola deleted the docker_ghaction branch March 27, 2024 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants