feat: support RISC-V 64 #297
Open
+246
−125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shanduur
force-pushed
the
riscv64-support
branch
3 times, most recently
from
fc2ab83
to
000288a
Compare
Signed-off-by: Mateusz Urbanek <mateusz.urbanek.98@gmail.com>
dereknola
requested changes
May 30, 2024
|
|
||
| "github.com/glebarez/go-sqlite" |
There was a problem hiding this comment.
You seem to have duplicate imports of this and line 25
| "github.com/k3s-io/kine/pkg/logstructured/sqllog" | ||
| "github.com/k3s-io/kine/pkg/server" | ||
| "github.com/k3s-io/kine/pkg/util" | ||
| "github.com/mattn/go-sqlite3" |
There was a problem hiding this comment.
Duplicate imports here and on line 24
| @@ -27,6 +28,7 @@ require ( | |||
| google.golang.org/grpc v1.56.3 | |||
| k8s.io/apimachinery v0.28.6 | |||
| k8s.io/client-go v0.28.6 | |||
| modernc.org/sqlite v1.28.0 | |||
There was a problem hiding this comment.
Is this related to github.com/mattn/go-sqlite3?
|
Why are you changing the code at all? This should just build as-is on riscv64.
I don't think we want that... what is wrong with using cgo on riscv64? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Treat it as POC, as I do not fully understand how the Dapper scripts work, but hey, it works for me!
How I tested it:
make ARCH=riscv64 docker run \ --rm --interactive --tty \ --volume=./bin/:/mnt/bin \ --platform=linux/riscv64 \ riscv64/busybox \ /mnt/bin/kineAlso, this adds pure Go implementation of SQLite3 client when building without CGO.
Closes #296