Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an option to show or hide the menu #14

Merged
merged 3 commits into from
Sep 29, 2021

Conversation

prototux
Copy link
Contributor

This add an checkbox (in the menu itself, with key F5 as well) "Show Menu", enabled/checked by default.

This option is useful in case the pinball is the only item displayed on the screen, in my case, as a fun addition on my mini arcade machine (https://i.imgur.com/nz3u48A.jpg) 🙂

Didn't tested it yet, i'll update the PR after it has been tested

@Sunlitspace542
Copy link

Sunlitspace542 commented Sep 29, 2021

I've tested this and can confirm it works, however, the F5 Key is already taken in the code, and the menu show/hide key wasn't added to the keyboard switch statement in options.cpp, after fixing these issues (set show ui to F9 in my case), it works.

@prototux
Copy link
Contributor Author

I've tested this and can confirm it works, however, the F5 Key is already taken in the code, and the menu show/hide key wasn't added to the keyboard switch statement in options.cpp, after fixing these issues (set show ui to F9 in my case), it works.

Thanks for the feedback! i've fixed both of these issues 🙂 didn't saw the F5 was already taken, sorry.

@@ -573,6 +584,9 @@ int winmain::event_handler(const SDL_Event* event)
pause();
options::keyboard();
break;
case SDLK_F0:
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be SDLK_F9, F0 is not defined.

@k4zmu2a
Copy link
Owner

k4zmu2a commented Sep 29, 2021

Other than F9 issue, everything else looks good to me, I will accept this.

@prototux
Copy link
Contributor Author

Other than F9 issue, everything else looks good to me, I will accept this.

And that's why coding at 3AM is a bad idea 😅 it should be fixed if i didn't messed up the history with the amend.

@k4zmu2a k4zmu2a merged commit 593b4d1 into k4zmu2a:master Sep 29, 2021
@k4zmu2a
Copy link
Owner

k4zmu2a commented Sep 29, 2021

Thank you, merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants