Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Identify and format all scoring options #16

Open
k5cents opened this issue Oct 4, 2020 · 1 comment
Open

Identify and format all scoring options #16

k5cents opened this issue Oct 4, 2020 · 1 comment
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@k5cents
Copy link
Owner

k5cents commented Oct 4, 2020

So far, we've just been using the applied total statistics. Aside from stat_correct(), the base level statistics are completely ignored.

The ESPNmythicalsports::get_player_stats() function uses tidyr::hoist() to just pull out the lower level stats and pivot them longer against the source and split. Packages for other languages might give some clue to what stat numbers mean what (see this npm package).

This is the last big component missing from #10 and might have to be pushed until after the initial CRAN milestone.

@k5cents k5cents added enhancement New feature or request help wanted Extra attention is needed labels Oct 4, 2020
@k5cents k5cents closed this as completed Jan 26, 2021
@k5cents k5cents reopened this Jan 26, 2021
@k5cents k5cents pinned this issue Sep 14, 2021
@k5cents
Copy link
Owner Author

k5cents commented Oct 16, 2021

The statId values for scoring settings have been manually identified and saved in stat_ids. However, there are still dozens of tracked statistics in the player entries that remain unidentified.

@k5cents k5cents unpinned this issue Sep 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant