-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create codeql-analysis.yml #1961
Conversation
Btw in my fork under You can see merge scan results here |
@jfcg, thanks for submitting this PR and sorry for the delay in responding! 😞 We are still unsure if we'd like to integrate CodeQL, since we already have extensive linter coverage for our Go code via golangci-lint. Besides, most of the results from this scan I can see are false-positives in our JS examples, for example: So, before we can merge this, it will have to be configured to check only Go code, not JavaScript... Though the 2 |
simplified the codeql file, includes only Go checks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Why did you remove the pull_request
build trigger?
Analysis takes some time and most projects I have contributed CodeQL patches/configurations preferred only on pushes. This is the leanest codeql configuration, but of course if you prefer they can also be added. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the delay here, I forgot to circle back and merge this 😞
Add Github CodeQL security checks for Go.