use object structure to allow multiple valid and invalid options for tests #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| should.deepEqual(data[0].assert(data[1][0]), data[1][1]); | ||
| should.deepEqual(data[0].assert(data[2][0]), data[2][1]); | ||
| it('#' + key, () => { | ||
| data.valid.forEach( e => { |
There was a problem hiding this comment.
It would be a better idea to name this something descriptive, such as testCase
|
Just a small nit, and if you could fix the commit message that would be awesome ^_^ thanks! After that it's good to go. I'm not sure how it could possibly have decreased coverage... |
|
Aha! Found the problem -- you're missing the |
|
💃 |
k88hudson
added a commit
that referenced
this pull request
Sep 2, 2015
use object structure to allow multiple valid and invalid options for tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor Validator.test.js to allow us to test an array of valid and invalid options. Switch to object structure, now uses:
validatorTerm,valid,invalid,invalidMessage