Supporting CaseInsensitive Queries #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have a DNS query `test.cloud.example.com` which returns a list of IP addresses. What should happen when you query `test.cloud.EXAMPLE.COM`. The answer is in the RFC https://www.rfc-editor.org/rfc/rfc4343#section-4.2. We return the same list of IP addresses for both queries. This also implies that if we maintain two dnsendpoints `test.cloud.example.com` with address `1.1.1.1` and `test.cloud.EXAMPLE.COM` with address `2.2.2.2`, we must return the merge `[1.1.1.1 2.2.2.2]` for both queries. Signed-off-by: Michal Kuritka <kuritka@gmail.com>
jeffhelps
approved these changes
Aug 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a DNS query
test.cloud.example.comwhich returns a list of IP addresses. What should happen when you querytest.cloud.EXAMPLE.COM. According to the RFC https://www.rfc-editor.org/rfc/rfc4343#section-4.2 we should return the same list of IP addresses for both queries.This also implies that if we maintain two dnsendpoints
test.cloud.example.comwith address1.1.1.1andtest.cloud.EXAMPLE.COMwith address2.2.2.2, we must return the merge[1.1.1.1 2.2.2.2]for both queries.This PR fixes queries processing and adds tests for this particular use-case.
Signed-off-by: Michal Kuritka kuritka@gmail.com