Refactor #2, Dig #257
Merged
Refactor #2, Dig #257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kuritka
requested review from
donovanmuller,
k0da,
somaritane and
ytsarev
as code owners
ytsarev
requested changes
Jan 15, 2021
| @@ -52,7 +53,7 @@ func (r *GslbReconciler) getGslbIngressIPs(gslb *k8gbv1beta1.Gslb) ([]string, er | |||
| gslbIngressIPs = append(gslbIngressIPs, ip.IP) | |||
| } | |||
| if len(ip.Hostname) > 0 { | |||
| IPs, err := Dig(r.Config.EdgeDNSServer, ip.Hostname) | |||
| IPs, err := utils.Dig(r.Config.EdgeDNSServer, ip.Hostname) | |||
| if err != nil { | |||
| return nil, err | |||
There was a problem hiding this comment.
as log.Info() was removed from Dig - we need to explicitly log it here, otherwise the failure of resolution will be hidden from the end user
- Tests for Dig require internet connection. If no internet connection available, tests are skipped automatically - Remove log.Info() from dig, instead return extended error
ytsarev
approved these changes
Jan 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to #255
utilslog.Info()from dig, instead return extended errorlog.Info()in caller functions