Bind env variables with ENV-BINDER, clearing tests #676
Conversation
kuritka
requested review from
donovanmuller,
jkremser,
k0da,
somaritane and
ytsarev
as code owners
|
✔️ Deploy Preview for k8gb-preview ready! 🔨 Explore the source changes: 39a25b3 🔍 Inspect the deploy log: https://app.netlify.com/sites/k8gb-preview/deploys/61766a641e109c0007e016bd 😎 Browse the preview: https://deploy-preview-676--k8gb-preview.netlify.app |
kuritka
changed the title
| @@ -80,62 +80,70 @@ const ( | |||
| type Log struct { | |||
| // Level [panic, fatal, error,warn,info,debug,trace], defines level of logger, default: info | |||
| Level zerolog.Level | |||
| // Format [simple,json] specifies how the logger prints values | |||
| // Format [simple,json] specifies how the logger prints values; 2=simple | |||
There was a problem hiding this comment.
I guess should be default=simple?
There was a problem hiding this comment.
It was forgotten because I first tried to bind an integer directly to an enum (it works, but it's terrible for the user).
comment modified, changes amended
There was a problem hiding this comment.
In terms of how we set the variables in the helm, nothing has changed at all. It's fully compatible
| // Username | ||
| Username string | ||
| Username string `env:"EXTERNAL_DNS_INFOBLOX_WAPI_USERNAME"` |
There was a problem hiding this comment.
Just a note for another PR, we need to get rid of EXTERNAL_DNS part in this env var name as technically it is not backed by external-dns anymore
| HTTPRequestTimeout int | ||
| // HTTPPoolConnections seconds; default = 10 | ||
| HTTPPoolConnections int | ||
| Password string `env:"EXTERNAL_DNS_INFOBLOX_WAPI_PASSWORD"` |
Thanks to ENV-BINDER we have moved the responsibility for bindings of environment variables to an external, well tested package. ENV-BINDER works with unexported fields, so we can bind the values of some fields and calculate a new value from them in the calculation phase. An example is enum, where env_variable has the value "info" but the internal state of the structure has the value 1. (I have also created a PR in [kelsyhightower/envconfig](kelseyhightower/envconfig#198), which solves the problem with private fields). Thanks to the delegation of responsibility I could delete about a third of the test without changing the depressolver coverage, which increased to 95% with the changes. Signed-off-by: kuritka <kuritka@gmail.com>
…ord (#688) Signed-off-by: Jimmy <speckmaier58@gmail.com> Signed-off-by: kuritka <kuritka@gmail.com>
Thanks to AbsaOSS/ENV-BINDER we have moved the responsibility for bindings of environment variables to an external, well tested package.
ENV-BINDER works with unexported fields, so we can bind the values of some fields and calculate a new value from them in the calculation phase. Such example is enum, where env_variable has the value "info" but the internal state of the structure has the value 1. (I have also created a PR in kelsyhightower/envconfig, which solves the problem with private fields, unfortunately it seems that nobody takes care of the library for a long time).
Thanks to the delegation of responsibility I could delete about a third of the test without changing the depressolver
coverage, which increased to 95% with the changes.
closes #683
Signed-off-by: kuritka kuritka@gmail.com