Count with LoadBalancer IP in Service status #911
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k0da
requested review from
donovanmuller,
kuritka,
somaritane,
ytsarev and
jkremser
as code owners
kuritka
reviewed
Jun 21, 2022
On AKS for example, service type LoadBalancer doesn't expose Hostname but direct IP. We need to look at both properties Signed-off-by: Dinar Valeev <dinar.valeev@absa.africa>
kuritka
approved these changes
Jun 21, 2022
|
works for me :) thanks for the quick fix! |
4 tasks
somaritane
reviewed
Jun 21, 2022
| }, | ||
| } | ||
| serviceIPs := []corev1.LoadBalancerIngress{ | ||
| {IP: "1.1.1.1"}, // rely on 1.1.1.1 response from Cloudflare |
There was a problem hiding this comment.
@k0da , are we really checking resolution by CloudFlare here or are these just mock test data?
https://blog.cloudflare.com/cloudflare-outage-on-june-21-2022/
There was a problem hiding this comment.
This is just a test data
There was a problem hiding this comment.
@k0da if it's just test data, then the comment describing that it's not should be removed. Looks like a copy-paste from https://github.com/k8gb-io/k8gb/blob/master/controllers/gslb_controller_test.go#L818 where we actually relying on Cloudflare's FQDN resolution
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On AKS for example, service type LoadBalancer doesn't expose Hostname
but direct IP.
We need to look at both properties
Signed-off-by: Dinar Valeev dinar.valeev@absa.africa