This repository has been archived by the owner on Aug 22, 2022. It is now read-only.
[ghost] Fix PVC creation #1360
Closed
[ghost] Fix PVC creation #1360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current common file is not enough if the .Value contains persistence item is different than "content".
For exemple if you specify these following values, the persistence item shared will not be processed:
```YAML
persistence:
content:
enabled: false
existingClaim: "pvc-nfs-ghost"
mountPath: "/var/lib/ghost/content"
shared:
enabled: true
mountPath: /shared
type: emptyDir
```
lcotonea
requested review from
billimek,
bjw-s,
carpenike and
onedr0p
as code owners
ghost
added
the
|
As stated in the original PR, I am not a big fan of iterating over the existing values. I tried installing the chart without enabling the |
|
Closed as discussed in #1359 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current common file is not enough if the .Value contains persistence item is different than "content".
For exemple if you specify these following values, the persistence item shared will not be processed:
Description of the change
All persistent items are computed in the hardcoded settings.
Benefits
We can specify none, only content, or several persistent items.
Possible drawbacks
None
Applicable issues
Additional information
Checklist
Chart.yamlaccording to semver.[home-assistant])./hack/gen-helm-docs.sh stable <chart>)