Skip to content
This repository has been archived by the owner on Aug 22, 2022. It is now read-only.

[mqtt-exporter] Add new chart #1584

Merged
merged 25 commits into from
Jun 3, 2022
Merged

Conversation

runningman84
Copy link
Contributor

@runningman84 runningman84 commented May 26, 2022

Description of the change

Benefits

Possible drawbacks

Applicable issues

  • fixes #

Additional information

Checklist

  • Title of the PR starts with chart name (e.g. [home-assistant])
  • Chart version bumped in Chart.yaml according to semver.
  • Chart artifacthub.io/changes changelog annotation has been updated in Chart.yaml. See Artifact Hub documentation for more info.
  • Variables have been documented in the values.yaml file.

@ghost ghost added size/L Categorises a PR that changes 100-499 lines, ignoring generated files. precommit:ok CI status: pre-commit validation successful changelog:ok CI status: changelog validation successful lint:ok CI status: linting successful install:failed CI status: install failed labels May 26, 2022
@ghost ghost added precommit:ok CI status: pre-commit validation successful changelog:ok CI status: changelog validation successful lint:ok CI status: linting successful install:ok CI status: install successful and removed precommit:ok CI status: pre-commit validation successful changelog:ok CI status: changelog validation successful lint:ok CI status: linting successful install:failed CI status: install failed labels May 26, 2022
@runningman84
Copy link
Contributor Author

@bjw-s @onedr0p @billimek is anybody able to merge this...?

@bjw-s
Copy link
Contributor

bjw-s commented May 27, 2022

@runningman84 It's not really appreciated to be tagging us this quickly. We are all people that do this for fun in our free time, while juggling other life responsibilities.

This means that sometimes a PR will sit a bit longer, sometimes it'll be done in 5 minutes.

charts/stable/mqtt-exporter/values.yaml Outdated Show resolved Hide resolved
charts/stable/mqtt-exporter/values.yaml Outdated Show resolved Hide resolved
charts/stable/mqtt-exporter/values.yaml Outdated Show resolved Hide resolved
charts/stable/mqtt-exporter/values.yaml Outdated Show resolved Hide resolved
charts/stable/mqtt-exporter/values.yaml Outdated Show resolved Hide resolved
charts/stable/mqtt-exporter/values.yaml Outdated Show resolved Hide resolved
charts/stable/mqtt-exporter/values.yaml Outdated Show resolved Hide resolved
charts/stable/mqtt-exporter/values.yaml Outdated Show resolved Hide resolved
.github/ct-install.yaml Outdated Show resolved Hide resolved
runningman84 and others added 7 commits May 27, 2022 14:30
Co-authored-by: Bᴇʀɴᴅ Sᴄʜᴏʀɢᴇʀs <me@bjw-s.dev>
Co-authored-by: Bᴇʀɴᴅ Sᴄʜᴏʀɢᴇʀs <me@bjw-s.dev>
Co-authored-by: Bᴇʀɴᴅ Sᴄʜᴏʀɢᴇʀs <me@bjw-s.dev>
Co-authored-by: Bᴇʀɴᴅ Sᴄʜᴏʀɢᴇʀs <me@bjw-s.dev>
Co-authored-by: Bᴇʀɴᴅ Sᴄʜᴏʀɢᴇʀs <me@bjw-s.dev>
Co-authored-by: Bᴇʀɴᴅ Sᴄʜᴏʀɢᴇʀs <me@bjw-s.dev>
Co-authored-by: Bᴇʀɴᴅ Sᴄʜᴏʀɢᴇʀs <me@bjw-s.dev>
@ghost ghost removed changelog:ok CI status: changelog validation successful install:ok CI status: install successful labels May 27, 2022
runningman84 and others added 3 commits May 27, 2022 15:12
Co-authored-by: Bᴇʀɴᴅ Sᴄʜᴏʀɢᴇʀs <me@bjw-s.dev>
@ghost ghost added precommit:ok CI status: pre-commit validation successful changelog:ok CI status: changelog validation successful install:ok CI status: install successful lint:ok CI status: linting successful and removed precommit:failed CI status: pre-commit validation failed labels May 27, 2022
@runningman84
Copy link
Contributor Author

okay I hope all request changes are included now.

Would you like having secure defaults?

securityContext:
  capabilities:
    drop:
     - ALL
  readOnlyRootFilesystem: true
  runAsNonRoot: true
  runAsUser: 65534

@bjw-s
Copy link
Contributor

bjw-s commented May 28, 2022

okay I hope all request changes are included now.

Looks like it, although the chart is still excluded from the install phase, so the additionalContainer ct-values file is not being tested now I think.

Would you like having secure defaults?

securityContext:
  capabilities:
    drop:
     - ALL
  readOnlyRootFilesystem: true
  runAsNonRoot: true
  runAsUser: 65534

That sounds like a good idea :-)

@ghost ghost added precommit:failed CI status: pre-commit validation failed and removed precommit:ok CI status: pre-commit validation successful changelog:ok CI status: changelog validation successful lint:ok CI status: linting successful install:ok CI status: install successful labels May 29, 2022
@ghost ghost added precommit:ok CI status: pre-commit validation successful changelog:ok CI status: changelog validation successful lint:failed CI status: linting failed install:ok CI status: install successful and removed precommit:failed CI status: pre-commit validation failed labels Jun 2, 2022
@ghost ghost added lint:ok CI status: linting successful and removed lint:failed CI status: linting failed labels Jun 2, 2022
@runningman84
Copy link
Contributor Author

is there anything else left?

@onedr0p onedr0p merged commit 93b52f1 into k8s-at-home:master Jun 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
changelog:ok CI status: changelog validation successful install:ok CI status: install successful lint:ok CI status: linting successful precommit:ok CI status: pre-commit validation successful size/L Categorises a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants