Skip to content
This repository has been archived by the owner on Aug 22, 2022. It is now read-only.

[ddclient] new chart #167

Merged
merged 6 commits into from Nov 16, 2020
Merged

[ddclient] new chart #167

merged 6 commits into from Nov 16, 2020

Conversation

onedr0p
Copy link
Member

@onedr0p onedr0p commented Nov 15, 2020

Special notes for your reviewer:

This takes a free-form config to configure ddclient.

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • Chart Version bumped
  • Variables are documented in the README.md
  • Title of the PR starts with chart name (e.g. [radarr])

@onedr0p onedr0p requested a review from bjw-s November 15, 2020 22:15
@onedr0p onedr0p changed the title add ddclient [ddclient] new chart Nov 15, 2020
@onedr0p onedr0p closed this Nov 15, 2020
@onedr0p onedr0p reopened this Nov 15, 2020
@onedr0p
Copy link
Member Author

onedr0p commented Nov 15, 2020

This is a service-less app. common library looks to expect a service

@bjw-s
Copy link
Contributor

bjw-s commented Nov 16, 2020

This is a service-less app. common library looks to expect a service

Hmmz... well, it actually has a service.enabled flag, but the container that is being generated doesn't check for that flag when setting the ports causing it to fail when applying.

@onedr0p onedr0p merged commit 4591106 into master Nov 16, 2020
@onedr0p onedr0p deleted the ddclient-common branch November 16, 2020 17:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants