This repository has been archived by the owner on Aug 22, 2022. It is now read-only.
[frigate] Deprecate chart #528
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
billimek
suggested changes
Feb 1, 2021
There was a problem hiding this comment.
Can we use the new chart GitHub repo URL instead of the helm repository URL? There won't be much discoverable by going to https://blakeblackshear.github.io/blakeshome-charts/
charts/frigate/README.md
Outdated
| ``` | ||
|
|
||
| Read through the [values.yaml](https://github.com/k8s-at-home/charts/blob/master/charts/frigate/values.yaml) file. It has several commented out suggested values. | ||
| This chart has been deprecated. Please use the official chart hosted at https://blakeblackshear.github.io/blakeshome-charts/. |
There was a problem hiding this comment.
Suggest changing this line to:
This chart has been deprecated. Please use the official chart hosted at https://github.com/blakeblackshear/blakeshome-charts/tree/master/charts/frigate.
charts/frigate/templates/NOTES.txt
Outdated
| echo "Visit http://127.0.0.1:5000 to use your application" | ||
| kubectl port-forward $POD_NAME 5000:5000 | ||
| {{- end }} | ||
| This chart has been deprecated. Please use the official chart hosted at https://blakeblackshear.github.io/blakeshome-charts/. |
There was a problem hiding this comment.
Suggest changing this line to:
This chart has been deprecated. Please use the official chart hosted at https://github.com/blakeblackshear/blakeshome-charts/tree/master/charts/frigate.
|
Sure thing, will modify them in a bit |
|
Done |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
Since the chart is now hosted by the app author, this chart can be deprecated.
Benefits
Possible drawbacks
Applicable issues
Additional information
Checklist
Chart.yamlaccording to semver.[home-assistant])