Skip to content
This repository has been archived by the owner on Aug 22, 2022. It is now read-only.

[intel-gpu-plugin] New chart #76

Merged
merged 1 commit into from Oct 2, 2020
Merged

[intel-gpu-plugin] New chart #76

merged 1 commit into from Oct 2, 2020

Conversation

bjw-s
Copy link
Contributor

@bjw-s bjw-s commented Oct 2, 2020

Implements #29

Special notes for your reviewer:

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • Chart Version bumped
  • Variables are documented in the README.md
  • Title of the PR starts with chart name (e.g. [radarr])

@bjw-s bjw-s marked this pull request as draft October 2, 2020 07:00
@bjw-s bjw-s marked this pull request as ready for review October 2, 2020 07:02
@bjw-s bjw-s requested a review from onedr0p October 2, 2020 08:51
@onedr0p
Copy link
Member

onedr0p commented Oct 2, 2020

@bjw-s would it make sense to add the nodeSelector as an option, this works like affinities but builtin for daemonsets

https://github.com/onedr0p/k3s-gitops/blob/master/deployments/kube-system/intel-gpu-plugin.yaml#L18

Copy link
Member

@onedr0p onedr0p left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nodeSelector would be nice

@onedr0p onedr0p self-requested a review October 2, 2020 12:38
Copy link
Member

@onedr0p onedr0p left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good

@onedr0p onedr0p merged commit ef5f8b3 into k8s-at-home:master Oct 2, 2020
@bjw-s bjw-s deleted the intel-gpu-plugin branch October 2, 2020 12:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants