Skip to content
This repository has been archived by the owner on Aug 22, 2022. It is now read-only.

[thelounge] Added new chart: The Lounge #794

Merged
merged 10 commits into from
Apr 16, 2021
Merged

[thelounge] Added new chart: The Lounge #794

merged 10 commits into from
Apr 16, 2021

Conversation

rwaltr
Copy link
Contributor

@rwaltr rwaltr commented Apr 16, 2021

Description of the change

Added new Chart for The Lounge

Benefits

New chart, new possibilities!

Possible drawbacks

Yet another chart

Additional information

Checklist

  • Chart version bumped in Chart.yaml according to semver.
  • Title of the PR starts with chart name (e.g. [home-assistant])
  • Variables are documented in the README.md (this can be done with using our helm-docs wrapper ./hack/gen-helm-docs.sh stable <chart>)

Signed-off-by: Ryan Walter <rwalt@pm.me>
Signed-off-by: Ryan Walter <rwalt@pm.me>
Signed-off-by: Ryan Walter <rwalt@pm.me>
Signed-off-by: Ryan Walter <rwalt@pm.me>
Signed-off-by: Ryan Walter <rwalt@pm.me>
Signed-off-by: Ryan Walter <rwalt@pm.me>
dirtycajunrice
dirtycajunrice previously approved these changes Apr 16, 2021
Copy link
Contributor

@dirtycajunrice dirtycajunrice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect!

@rwaltr
Copy link
Contributor Author

rwaltr commented Apr 16, 2021

CI running issues fixed
Ready for review

@rwaltr rwaltr mentioned this pull request Apr 16, 2021
charts/stable/thelounge/values.yaml Outdated Show resolved Hide resolved
Signed-off-by: Ryan Walter <rwalt@pm.me>
@rwaltr rwaltr requested a review from bjw-s April 16, 2021 06:12
Copy link
Contributor

@bjw-s bjw-s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, looks great!

@bjw-s bjw-s merged commit b4cc349 into k8s-at-home:master Apr 16, 2021
@rwaltr rwaltr deleted the newchart-thelounge branch April 16, 2021 06:32
@onedr0p
Copy link
Member

onedr0p commented Apr 19, 2021

@all-contributors add @rwaltr for code

@allcontributors
Copy link
Contributor

@onedr0p

I've put up a pull request to add @rwaltr! 🎉

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants