Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Ruby 2.7 warnings (required updating to the latest dry-types version) #18

Merged
merged 1 commit into from Jan 12, 2022

Conversation

elthariel
Copy link
Collaborator

This PR upgrades to the latest dry-types to get rid of the ruby 2.7 keyword argument warning. It also fixes the spec to remove most warning. A few remain that aren't fixed in rspec and recursive open struct

@matti
Copy link
Contributor

matti commented Jan 4, 2022

@elthariel I invited you to write to the repository. If you still have energy, please merge these.

@matti matti merged commit 335639c into k8s-ruby:master Jan 12, 2022
@matti
Copy link
Contributor

matti commented Jan 12, 2022

merging anyway, nobody maintains this gem, trying to get this working with 3.x now

matti added a commit that referenced this pull request Jan 12, 2022
@matti
Copy link
Contributor

matti commented Jan 12, 2022

didn't work, reverted

@dwillett
Copy link
Collaborator

Hey @matti - I was looking at changes needed to support 3.0.x as well, wondering what remaining issues you were seeing?

@matti
Copy link
Contributor

matti commented Jan 20, 2022 via email

@dwillett
Copy link
Collaborator

dwillett commented Jan 20, 2022

More so than what was accounted for in this reverted merge? I made similar changes in my fork here to bring it up to compatibility and my unit tests are passing. Wondering if there are additional errors I'm not seeing: dwillett@c39e7de

edit: made some additional updates to fix the docker-compose for 2.6, 2.7. and 3.0

@matti
Copy link
Contributor

matti commented Jan 26, 2022

@dwillett the error was that Gemfile.lock is not in version control and therefore I couldn't bundle.

merged your master and released as 0.12.0

also sent you an invite to become a maintainer: https://github.com/k8s-ruby/k8s-ruby/invitations

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants