Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: rework auth commands #438

Merged

Conversation

matthisholleville
Copy link
Contributor

Closes #437

📑 Description

This PR includes two commits:

  1. feat: Rework "auth remove" command for improved consistency with other remove commands, such as "filters remove".
  2. feat: Rename "auth new" command to "auth add". This modification enhances consistency throughout the codebase.

These changes aim to enhance the overall consistency and maintainability of the codebase by aligning command names and behaviors.

✅ Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

ℹ Additional Information

This change allows to be more consistent with the rest of the code

Signed-off-by: Matthis Holleville <matthish29@gmail.com>
…mmands like "filters remove"

Signed-off-by: Matthis Holleville <matthish29@gmail.com>
Signed-off-by: Matthis Holleville <matthish29@gmail.com>
@matthisholleville matthisholleville requested review from a team as code owners May 18, 2023 14:28
@matthisholleville matthisholleville merged commit c659a87 into k8sgpt-ai:main May 18, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[Chore]: auth "new" does not fit "add' convention
2 participants