Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Chore]: auth "new" does not fit "add' convention #437

Closed
2 tasks done
AlexsJones opened this issue May 18, 2023 · 0 comments · Fixed by #438
Closed
2 tasks done

[Chore]: auth "new" does not fit "add' convention #437

AlexsJones opened this issue May 18, 2023 · 0 comments · Fixed by #438
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@AlexsJones
Copy link
Member

Checklist

  • I've searched for similar issues and couldn't find anything matching
  • I've discussed this feature request in the K8sGPT Slack and got positive feedback

Is this feature request related to a problem?

No

Problem Description

No response

Solution Description

This is out of convention with other command trees such as filters add/remove

Benefits

Conformance with the rest of the commands

Potential Drawbacks

No response

Additional Information

No response
@AlexsJones AlexsJones added enhancement New feature or request good first issue Good for newcomers labels May 18, 2023
@matthisholleville matthisholleville mentioned this issue May 18, 2023
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
Backlog
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: rework auth commands matthisholleville/k8sgpt
1 participant
@AlexsJones